izumo27 commented on code in PR #575:
URL: https://github.com/apache/pulsar-client-cpp/pull/575#discussion_r3217882826
##########
include/pulsar/Authentication.h:
##########
@@ -530,7 +541,14 @@ class PULSAR_PUBLIC AuthOauth2 : public Authentication {
/**
* Create an AuthOauth2 with a ParamMap
*
- * The required parameter keys are “issuer_url”, “private_key”, and
“audience”
+ * For `tokenEndpointAuthMethod = "client_secret_post"` (default), the
required parameter
+ * keys are “issuer_url”, “private_key”, and “audience”.
+ * Optional keys: `scope`, `tls_cert_file`, `tls_key_file`.
Review Comment:
Although the RFC defines `audience` as an optional parameter, it remains
required for `client_secret_post` to avoid a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
