mattisonchao commented on code in PR #1494:
URL: https://github.com/apache/pulsar-client-go/pull/1494#discussion_r3233525333
##########
pulsar/consumer_impl.go:
##########
@@ -53,7 +54,7 @@ type consumer struct {
topic string
client *client
options ConsumerOptions
- consumers []*partitionConsumer
+ consumers atomic.Value
Review Comment:
This change will make the `internalTopicSubscribeToPartitions` method not
atomic. That means you can receive messages during the partition changes, but
you can't ack them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
