zhanglistar opened a new pull request, #25812:
URL: https://github.com/apache/pulsar/pull/25812

   ### Motivation
   
   Apache Pulsar PR #16333 introduced 
`bookkeeperClientSeparatedIoThreadsEnabled` so the BookKeeper client can use a 
dedicated IO thread pool instead of sharing the broker's Pulsar 
`EventLoopGroup`. The upstream default remained `false` for backward 
compatibility.
   
   In our deployment, sharing IO threads between the broker and the BookKeeper 
client can cause contention under storage-heavy workloads. Enabling separated 
IO threads by default isolates BookKeeper network I/O from broker I/O and 
better matches our production expectations.
   
   ### Modifications
   
   - Set `bookkeeperClientSeparatedIoThreadsEnabled=true` in `conf/broker.conf` 
and `conf/standalone.conf`, and update related comments.
   - Change the Java default in `ServiceConfiguration` from `false` to `true`, 
and update `@FieldContext` documentation.
   - Update unit tests to reflect the new default:
     - `ServiceConfigurationTest#testBookKeeperClientIoThreads`
     - `BookKeeperClientFactoryImplTest#testBookKeeperIoThreadsConfiguration`
   
   Operators who want the previous behavior can set:
   
   ```properties
   bookkeeperClientSeparatedIoThreadsEnabled=false
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to