merlimat commented on PR #25827: URL: https://github.com/apache/pulsar/pull/25827#issuecomment-4499151118
Closing as superseded by #25794, which was merged earlier and fixes the same flakiness in `CompactionConcurrencyTest.testDisableCompactionConcurrently` with a more robust approach. #25794 deterministically forces the concurrent-delete race by blocking the `currentCompaction` future, so it preserves the original test intent (the second delete reliably fails with `PreconditionFailedException`, the first succeeds, and `disablingCompaction` is verified to reset). My PR instead dropped the "at least one fails" assertion, which loses that coverage. Their fix is better — thanks @void-ptr974. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
