Dream95 opened a new pull request, #25867:
URL: https://github.com/apache/pulsar/pull/25867
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
<!-- or this PR is one task of an issue -->
<!-- If the PR belongs to a PIP, please add the PIP link here -->
<!-- Details of when a PIP is required and how the PIP process work, please
see: https://github.com/apache/pulsar/blob/master/pip/README.md -->
### Motivation
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
Go function runtime currently exits the processing loop when user code
returns an error, which causes behavior inconsistency with Java/Python runtimes
and prevents expected retry/negative-ack flow in failure scenarios.
This PR aligns Go runtime behavior for user-function failures and adds
integration coverage for Go neg-ack semantics.
This PR aligns Go runtime behavior for user-function failures and adds
integration coverage for Go neg-ack semantics.
### Modifications
<!-- Describe the modifications you've done. -->
- In `pulsar-function-go/pf/instance.go`:
- Refactored error handling into helper methods (`handleUserError`,
`handlePublishError`).
- Changed user-function error path from returning error (exit loop) to
continuing message processing.
- Added `shouldNackInputOnFailure()` and enabled `nack` for `ATLEAST_ONCE`
and `MANUAL` on user-function failures.
- Kept publish-error handling with system exception metrics and
appropriate ack/nack behavior.
- In `pulsar-function-go/pf/instance_test.go`:
- Added Go exception function example:
`tests/docker-images/latest-version-image/go-examples/exceptionFunc/exceptionFunc.go`.
- Updated Docker image build to include the new Go example artifact.
- Added `testGoFunctionNegAck` in Go integration test suite.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
~~~ shell
./gradlew :tests:docker-images:latest-version-image:dockerBuild
./gradlew :tests:integration:integrationTest \
-PintegrationTestSuiteFile=pulsar-process.xml \
--tests
"org.apache.pulsar.tests.integration.functions.go.PulsarFunctionsGoProcessTest.testGoFunctionNegAck"
~~~
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
