merlimat commented on a change in pull request #5491: Fix message deduplicate
issue while using external sequence id with batch produce
URL: https://github.com/apache/pulsar/pull/5491#discussion_r341263026
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
##########
@@ -257,6 +285,9 @@ public ServerCnx getCnx() {
private String originalProducerName;
private long originalSequenceId;
+ private long lowestSequenceId;
Review comment:
Ok, though as in other comment, there's already a `sequenceId` field. Is
that now ignored? If yes, then it should be removed.
Also, as you can see, there's an `originalSequenceId` field. This is used in
the context of geo-replication and it would have to be accounted for as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
