addisonj commented on a change in pull request #5400: [functions] Allow
functions to pass runtime specific options
URL: https://github.com/apache/pulsar/pull/5400#discussion_r344416849
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
##########
@@ -181,24 +186,23 @@ public void initialize(WorkerConfig workerConfig,
AuthenticationConfig authentic
this.javaInstanceJarFile = this.pulsarRootDir +
"/instances/java-instance.jar";
this.pythonInstanceFile = this.pulsarRootDir +
"/instances/python-instance/python_instance_main.py";
this.serverCaBytes = workerConfig.getTlsTrustChainBytes();
+ this.manifestCustomizerClassName =
factoryConfig.getKubernetesManifestCustomizerClassName();
+ this.manifestCustomizerStaticConfig =
factoryConfig.getKubernetesManifestCustomizerConfig();
try {
setupClient();
} catch (Exception e) {
log.error("Failed to setup client", e);
throw new RuntimeException(e);
}
- if (functionAuthProvider.isPresent()) {
- if (!(functionAuthProvider.get() instanceof
KubernetesFunctionAuthProvider)) {
+ this.authProviderClassName = functionAuthProviderClass;
Review comment:
see comment here https://github.com/apache/pulsar/pull/5400/files#r344416501
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
