sijie commented on a change in pull request #5675: fix bkenv has no effect bug
when start bookie using bin/pulsar-daemon
URL: https://github.com/apache/pulsar/pull/5675#discussion_r347309990
##########
File path: bin/pulsar
##########
@@ -44,12 +44,18 @@
FUNCTIONS_EXTRA_DEPS_DIR=${PULSAR_FUNCTIONS_EXTRA_DEPS_DIR:-"${DEFAULT_FUNCTIONS
SQL_HOME=$PULSAR_HOME/pulsar-sql
PRESTO_HOME=${PULSAR_HOME}/lib/presto
-
+# Check pulsar env and load pulser_env.sh
if [ -f "$PULSAR_HOME/conf/pulsar_env.sh" ]
then
. "$PULSAR_HOME/conf/pulsar_env.sh"
fi
+# Check bookkeeper env and load bkenv.sh
Review comment:
Move this before line 47 for backward compatibility consideration.
So if people already define environments in pulsar_env, those env vars will
not be overridden by bkenv.sh.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
