[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5745: Add document for sticky consumer

[GitBox]

Anonymitaet commented on a change in pull request #5745: Add document for 
sticky consumer 
URL: https://github.com/apache/pulsar/pull/5745#discussion_r350621322
 
 

 ##########
 File path: site2/docs/client-libraries-java.md
 ##########
 @@ -607,6 +607,19 @@ consumer 2 will receive:
 ("key-4", "message-4-2")
 ```
 
+By default, consumer in `Key_Shared` subscription will be assigned a fixed 
hash range of key automatically. If you want to specify the hash ranges of a 
consumer, you can using the key shared policy:
 
 Review comment:
   1. For key_shared subscription, there are many inconsistencies (issues of 
capitalization and backtick) in Pulsar doc
   
   * w/o backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615827-86131300-1070-11ea-82cc-336a86adaf9b.png)
   
   * w/ backtick
   
![image](https://user-images.githubusercontent.com/50226895/69615747-61b73680-1070-11ea-9e5f-098ea6bf081e.png)
   
   **Shall we use `Key_Shared` subscription overall?**
   
   2. Do you mean changing it to the following?
   
   `By default, a consumer in the Key_Shared subscription is assigned a fixed 
hash range of keys automatically. If you want to specify the hash ranges of a 
consumer, you can use the key shared policy:`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services