codelipenghui commented on a change in pull request #5782: Modify the logical
in producer carry a schema to connect broker with isAllowAutoUpdateSchema.
URL: https://github.com/apache/pulsar/pull/5782#discussion_r352604737
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
##########
@@ -111,7 +111,8 @@
@Override
@NotNull
public CompletableFuture<SchemaVersion> putSchemaIfAbsent(String schemaId,
SchemaData schema,
-
SchemaCompatibilityStrategy strategy) {
+
SchemaCompatibilityStrategy strategy,
+ boolean
isAllowCreateSchema) {
Review comment:
Looks weird here, i think we'd better add a method to get schema version by
schemaData which producer carried, if the the exists schemas contains the
schema that producer carried, producer can connect success, otherwise if not
allow schema auto update, reject the producer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
