codelipenghui commented on a change in pull request #5784: Create load balance
znode of broker when znode missed.
URL: https://github.com/apache/pulsar/pull/5784#discussion_r352930533
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
##########
@@ -869,7 +868,13 @@ public void writeBrokerDataOnZooKeeper() {
updateLocalBrokerData();
if (needBrokerDataUpdate()) {
localData.setLastUpdate(System.currentTimeMillis());
- zkClient.setData(brokerZnodePath, localData.getJsonBytes(),
-1);
+
+ try {
+ zkClient.setData(brokerZnodePath,
localData.getJsonBytes(), -1);
+ } catch (KeeperException.NoNodeException e) {
+ ZkUtils.createFullPathOptimistic(zkClient,
brokerZnodePath, localData.getJsonBytes(),
Review comment:
Yes, Frequently appear in our recent performance tests, #5673 describe the
problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
