zhaohaidao commented on a change in pull request #5767: Support batch
authorization of partitioned topic
URL: https://github.com/apache/pulsar/pull/5767#discussion_r353499759
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -312,4 +316,76 @@ public void testGetPartitionedTopicsList() throws
KeeperException, InterruptedEx
Assert.assertEquals(nonPersistentPartitionedTopics.size(), 1);
Assert.assertEquals(TopicName.get(nonPersistentPartitionedTopics.get(0)).getDomain().value(),
TopicDomain.non_persistent.value());
}
+
+ @Test
+ public void testGrantNonPartitionedTopic() {
+ final String topicName = "non-partitioned-topic";
+ persistentTopics.createNonPartitionedTopic(testTenant, testNamespace,
topicName, true);
+ String role = "role";
+ Set<AuthAction> expectActions = new HashSet<>();
+ expectActions.add(AuthAction.produce);
+ persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
topicName, role, expectActions);
+ Map<String, Set<AuthAction>> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace, topicName);
+ Assert.assertEquals(permissions.get(role), expectActions);
+ }
+
+ @Test
+ public void testGrantPartitionedTopic() {
+ final String partitionedTopicName = "partitioned-topic";
+ final int numPartitions = 5;
+ persistentTopics.createPartitionedTopic(testTenant, testNamespace,
partitionedTopicName, numPartitions);
+
+ String role = "role";
+ Set<AuthAction> expectActions = new HashSet<>();
+ expectActions.add(AuthAction.produce);
+ persistentTopics.grantPermissionsOnTopic(testTenant, testNamespace,
partitionedTopicName, role, expectActions);
+ Map<String, Set<AuthAction>> permissions =
persistentTopics.getPermissionsOnTopic(testTenant, testNamespace,
+ partitionedTopicName);
+ Assert.assertEquals(permissions.get(role), expectActions);
+ TopicName topicName = TopicName.get(TopicDomain.persistent.value(),
testTenant, testNamespace,
+ partitionedTopicName);
+ for (int i = 0; i < numPartitions; i++) {
+ TopicName partition = topicName.getPartition(i);
+ Map<String, Set<AuthAction>> partitionPermissions =
persistentTopics.getPermissionsOnTopic(testTenant,
+ testNamespace, partition.getEncodedLocalName());
Review comment:
Thanks for reminding. PersistentTopicsTest passed locally.
I use getEncodedLocalName because the parameter for the rest API
getPermissionsOnTopic is named encodedTopic as followed.
```java
public Map<String, Set<AuthAction>> getPermissionsOnTopic(
@ApiParam(value = "Specify the tenant", required = true)
@PathParam("tenant") String tenant,
@ApiParam(value = "Specify the namespace", required = true)
@PathParam("namespace") String namespace,
@ApiParam(value = "Specify topic name", required = true)
@PathParam("topic") @Encoded String encodedTopic) {
validateTopicName(tenant, namespace, encodedTopic);
return internalGetPermissionsOnTopic();
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
