cckellogg commented on a change in pull request #5790: [Issue:5687] Add prefix
for new keys from Env
URL: https://github.com/apache/pulsar/pull/5790#discussion_r354466596
##########
File path: deployment/kubernetes/aws/broker.yaml
##########
@@ -25,15 +25,15 @@ metadata:
data:
# Tune for available memory. Increase the heap up to 24G to have
# better GC behavior at high throughput
- PULSAR_MEM: "\" -Dio.netty.leakDetectionLevel=disabled
-Dio.netty.recycler.linkCapacity=1024 -XX:+ParallelRefProcEnabled
-XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis
-XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50
-XX:+DisableExplicitGC -XX:-ResizePLAB -XX:+ExitOnOutOfMemoryError
-XX:+PerfDisableSharedMem -Xms12g -Xmx12g -XX:MaxDirectMemorySize=14g
-Dpulsar.root.logger=DEBUG,FILE \""
- PULSAR_GC: "\" -XX:+UseG1GC -XX:MaxGCPauseMillis=10\""
- zookeeperServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper
- configurationStoreServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper
- clusterName: us-east
- managedLedgerDefaultEnsembleSize: "2"
- managedLedgerDefaultWriteQuorum: "2"
- managedLedgerDefaultAckQuorum: "2"
- deduplicationEnabled: "false"
+ PULSAR_PREFIX_PULSAR_MEM: "\" -Dio.netty.leakDetectionLevel=disabled
-Dio.netty.recycler.linkCapacity=1024 -XX:+ParallelRefProcEnabled
-XX:+UnlockExperimentalVMOptions -XX:+AggressiveOpts -XX:+DoEscapeAnalysis
-XX:ParallelGCThreads=32 -XX:ConcGCThreads=32 -XX:G1NewSizePercent=50
-XX:+DisableExplicitGC -XX:-ResizePLAB -XX:+ExitOnOutOfMemoryError
-XX:+PerfDisableSharedMem -Xms12g -Xmx12g -XX:MaxDirectMemorySize=14g
-Dpulsar.root.logger=DEBUG,FILE \""
Review comment:
This change only helps if the user builds their own image or waits for a
release image. This change still dumps unexpected values into config files that
do no expect it. Does that matter? Changing the chart might be a slightly
bigger change but it fixes the problem for users on past releases images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
