jiazhai commented on a change in pull request #5829: [Issue 5827][Issue
5828][netty] Fixes for UDP protocol support in netty connector
URL: https://github.com/apache/pulsar/pull/5829#discussion_r355825080
##########
File path:
pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
##########
@@ -96,7 +96,7 @@ private void runUdp() throws InterruptedException {
Bootstrap bootstrap = new Bootstrap();
bootstrap.group(workerGroup);
bootstrap.channel(NioDatagramChannel.class);
- bootstrap.handler(new NettyChannelInitializer(new
NettyServerHandler(this.nettySource)))
+ bootstrap.handler(new NettyChannelInitializer(new
NettyUDPServerHandler(this.nettySource)))
Review comment:
This change lgtm.
Just have a question maybe not related with this issue. Since this is
replaced with `NettyUDPServerHandler`, Is there a need to replace the
`NettyServerHandler` in function `runTcp` below in line 108?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
