codelipenghui commented on a change in pull request #5915: Allow to
enable/disable delayed delivery for messages on namespace
URL: https://github.com/apache/pulsar/pull/5915#discussion_r368353184
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
##########
@@ -718,7 +718,7 @@ public void
initializeDispatchRateLimiterIfNeeded(Optional<Policies> policies) {
@Override
public boolean trackDelayedDelivery(long ledgerId, long entryId,
MessageMetadata msgMetadata) {
- if (!isDelayedDeliveryEnabled) {
+ if (!isDelayedDeliveryEnabled || !topic.delayedDeliveryEnabled) {
Review comment:
I think you can remove the isDelayedDeliveryEnabled in dispatcher, maybe we
just need it on topic level on subscription level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
