sijie opened a new pull request #6102:  [Websocket] Websocket doesn't set the 
correct cluster data
URL: https://github.com/apache/pulsar/pull/6102
 
 
   *Motivation*
   
   Fixes #5997
   Fixes #6079
   
   A regression was introduced in #5486. If websocket service as running as 
part of
   pulsar standalone, the cluster data is set with null service urls. This 
causes
   service url is not set correctly in the pulsar client and an illegal 
argument exception
   ("Param serviceUrl must not be blank.") will be thrown.
   
   *Modifications*
   
   1. Pass `null` when constructing the websocket service. So the local cluster 
data can
      be refreshed when creating pulsar client.
   2. Set the cluster data after both broker service and web service started 
and ports are allocated.
   
   *Test*
   
   Verified locally and need to figure out how to automate this in integration 
tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to