sijie commented on a change in pull request #6034: [Pulsar IO][Issue
5633]Support avro schema for debezium connector
URL: https://github.com/apache/pulsar/pull/6034#discussion_r376142610
##########
File path:
pulsar-io/kafka-connect-adaptor/src/main/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSource.java
##########
@@ -188,15 +198,48 @@ public void close() {
@Getter
Optional<String> destinationTopic;
+ private final AvroData avroData;
+
+ private org.apache.pulsar.kafka.shade.avro.Schema keyAvroSchema;
+
+ private org.apache.pulsar.kafka.shade.avro.Schema valueAvroSchema;
+
+ private final KafkaSchema keySchema;
+
+ private final KafkaSchema valueSchema;
+
+ private byte[] keyBytes;
Review comment:
why do we need to make this variable a class variable? it is only used in
the constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
