gaoran10 commented on a change in pull request #6381: [Issue 6283][Offloaders] WIP - Offload policies per ns with deletionLag & threshold URL: https://github.com/apache/pulsar/pull/6381#discussion_r382892359
########## File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPolicies.java ########## @@ -39,11 +39,15 @@ public final static int DEFAULT_OFFLOAD_MAX_THREADS = 2; public final static String[] DRIVER_NAMES = {"S3", "aws-s3", "google-cloud-storage", "filesystem"}; public final static String DEFAULT_OFFLOADER_DIRECTORY = "./offloaders"; + public final static long DEFAULT_OFFLOAD_OFFLOAD_THRESHOLD = -1; + public final static Long DEFAULT_OFFLOAD_OFFLOAD_DELETION_LAG_MS = null; Review comment: Maybe the default value of this config could keep the original value (4 hours). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services