rdhabalia commented on issue #6782: URL: https://github.com/apache/pulsar/pull/6782#issuecomment-617325609
There are few issues here: 1. User can set `Authentication` with [3 different ways](https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java#L102-L120): a. set `pluginName` and `paramString` b. set `pluginName` and `paramMap` c. user creates `Authentication` object and set it. Fix: #4284 only handles (a) and it can't handle (b) and (c). PulsarSpout and PulsarBolt accepts `ClientBuilder` which directly sets `Authentication` in clientConfigData (so, clientConfigData will never have any params) and most of the users directly set `Authentication` and making it `transient` will totally break their existing code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
