Anonymitaet commented on a change in pull request #6763:
URL: https://github.com/apache/pulsar/pull/6763#discussion_r414238608
##########
File path: site2/docs/security-encryption.md
##########
@@ -144,11 +148,12 @@ for (int i = 0; i < 10; i++) {
// Acknowledge the consumption of all messages at once
consumer.acknowledgeCumulative(msg);
+consumer.close();
pulsarClient.close();
```
## Key rotation
-Pulsar generates new AES data key every 4 hours or after publishing a certain
number of messages. A producer fetches the asymmetric public key every 4 hours
by calling CryptoKeyReader::getPublicKey() to retrieve the latest version.
+Pulsar generates new AES data key every 4 hours or after publishing a certain
number of messages. A producer fetches the asymmetric public key every 4 hours
by calling CryptoKeyReader.getPublicKey() to retrieve the latest version.
Review comment:
```suggestion
Pulsar generates a new AES data key every 4 hours or after publishing a
certain number of messages. A producer fetches the asymmetric public key every
4 hours by calling CryptoKeyReader.getPublicKey() to retrieve the latest
version.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
