[GitHub] [pulsar] jiazhai commented on a change in pull request #4848: Consumer can getValue return null

[GitBox]

jiazhai commented on a change in pull request #4848:
URL: https://github.com/apache/pulsar/pull/4848#discussion_r414277906



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
##########
@@ -270,7 +270,11 @@ public T getValue() {
                     return schema.decode(getData(), schemaVersion);
                 }
             } else {
-                return schema.decode(getData());
+                if (getData().length == 0) {

Review comment:
       we should use metadata to store the null payload.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org