hangc0276 commented on pull request #6776:
URL: https://github.com/apache/pulsar/pull/6776#issuecomment-619380515
> > > @hangc0276 Good catch! @wolfstudy could please help take a look the
last comment? maybe you need to move the `messageId` to the end of params list.
> >
> >
> > Thanks for your feedback. @wolfstudy maybe you should implement a
constructor for `MessageIdImpl`，which param is a string, and you should parse
string to `MessageIdImpl` field, such as ledgerId, entryId and partitionIndex.
Because the QueryParam just pass a string as param to messgeId, you should
construct a MessageIdImpl object using the string param.
>
> Good idea, maybe we can send a new issue to track this, the proposal will
change the current default behavior. We can modify it in a separate pull
request.
But i am afraid your present implementation will compile failed due to lack
of `MessageIdImpl` constructor for `@QueryParam("messageId")
@DefaultValue("latest") MessageIdImpl messageId,`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
