Anonymitaet commented on a change in pull request #7031:
URL: https://github.com/apache/pulsar/pull/7031#discussion_r429744614



##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |

Review comment:
       ```suggestion
   | split_bytes_read | Counter | Number of bytes read from BookKeeper. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |
+| split_message_queue_enqueue_wait_time_per_query | Summary | Time spent 
waiting for message queue enqueue because message queue is full per query. |
+| split_num_entries_per_batch | Summary | Number of entries per batch. |
+| split_num_entries_per_query | Summary | Number of entries per query. |
+| split_num_messages_deserialized_per_entry | Summary | Number of messages 
deserialized per entry. |
+| split_num_messages_deserialized_per_query | Summary | Number of messages 
deserialized per query. |
+| split_read_attempts | Summary | Number of read attempts(will fail if queues 
are full). |
+| split_read_attempts_per_query | Summary | Number of read attempts per query. 
|
+| split_read_latency_per_batch | Summary | Latency of reads per batch. |
+| split_read_latency_per_query | Summary | Total read latency per query. |
+| split_record_deserialize_time | Summary | Time spent deserializing message 
to record e.g. avro, json, etc. |

Review comment:
       ```suggestion
   | split_record_deserialize_time | Summary | Time spent on deserializing 
message to record. For example, Avro, JSON, and so on. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |

Review comment:
       ```suggestion
   | split_entry_deserialize_time | Summary | Time spent on derserializing 
entries. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |
+| split_message_queue_enqueue_wait_time_per_query | Summary | Time spent 
waiting for message queue enqueue because message queue is full per query. |
+| split_num_entries_per_batch | Summary | Number of entries per batch. |
+| split_num_entries_per_query | Summary | Number of entries per query. |
+| split_num_messages_deserialized_per_entry | Summary | Number of messages 
deserialized per entry. |
+| split_num_messages_deserialized_per_query | Summary | Number of messages 
deserialized per query. |
+| split_read_attempts | Summary | Number of read attempts(will fail if queues 
are full). |
+| split_read_attempts_per_query | Summary | Number of read attempts per query. 
|
+| split_read_latency_per_batch | Summary | Latency of reads per batch. |
+| split_read_latency_per_query | Summary | Total read latency per query. |
+| split_record_deserialize_time | Summary | Time spent deserializing message 
to record e.g. avro, json, etc. |
+| split_record_deserialize_time_per_query | Summary | Time spent deserializing 
message to record per query. |

Review comment:
       ```suggestion
   | split_record_deserialize_time_per_query | Summary | Time spent on 
deserializing message to record per query. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |

Review comment:
       ```suggestion
   | split_num_record_deserialized | Counter | Number of records deserialized. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |

Review comment:
       ```suggestion
   | split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spent 
on waiting to get entry from entry queue per query. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |
+| split_message_queue_enqueue_wait_time_per_query | Summary | Time spent 
waiting for message queue enqueue because message queue is full per query. |
+| split_num_entries_per_batch | Summary | Number of entries per batch. |
+| split_num_entries_per_query | Summary | Number of entries per query. |
+| split_num_messages_deserialized_per_entry | Summary | Number of messages 
deserialized per entry. |
+| split_num_messages_deserialized_per_query | Summary | Number of messages 
deserialized per query. |
+| split_read_attempts | Summary | Number of read attempts(will fail if queues 
are full). |
+| split_read_attempts_per_query | Summary | Number of read attempts per query. 
|
+| split_read_latency_per_batch | Summary | Latency of reads per batch. |
+| split_read_latency_per_query | Summary | Total read latency per query. |
+| split_record_deserialize_time | Summary | Time spent deserializing message 
to record e.g. avro, json, etc. |
+| split_record_deserialize_time_per_query | Summary | Time spent deserializing 
message to record per query. |
+| split_total_execution_time | Summary | Total time spent execution time . |

Review comment:
       ```suggestion
   | split_total_execution_time | Summary | Total execution time. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |

Review comment:
       ```suggestion
   | split_entry_queue_dequeue_wait_time | Summary | Time spent on waiting to 
get entry from entry queue because it is empty. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |

Review comment:
       ```suggestion
   | split_entry_deserialize_time_per_query | Summary | Time spent on 
derserializing entries per query. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |
+| split_message_queue_enqueue_wait_time_per_query | Summary | Time spent 
waiting for message queue enqueue because message queue is full per query. |
+| split_num_entries_per_batch | Summary | Number of entries per batch. |
+| split_num_entries_per_query | Summary | Number of entries per query. |
+| split_num_messages_deserialized_per_entry | Summary | Number of messages 
deserialized per entry. |
+| split_num_messages_deserialized_per_query | Summary | Number of messages 
deserialized per query. |
+| split_read_attempts | Summary | Number of read attempts(will fail if queues 
are full). |

Review comment:
       ```suggestion
   | split_read_attempts | Summary | Number of read attempts (fail if queues 
are full). |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |

Review comment:
       ```suggestion
   | split_entry_deserialize_time_per_query | Summary | Time spent on 
derserializing entries per query. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |

Review comment:
       ```suggestion
   | split_message_queue_dequeue_wait_time_per_query | Summary | Time spent on 
waiting to dequeue from message queue because it is empty per query. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |

Review comment:
       ```suggestion
   | split_message_queue_enqueue_wait_time | Summary | Time spent on waiting 
for message queue because the message queue is full. |
   ```

##########
File path: site2/docs/reference-metrics.md
##########
@@ -359,6 +360,34 @@ All the proxy metrics are labelled with the following 
labels:
 | pulsar_proxy_binary_ops | Counter | Counter of proxy operations. |
 | pulsar_proxy_binary_bytes | Counter | Counter of proxy bytes. |
 
+# Pulsar SQL Worker
+
+| Name | Type | Description |
+|---|---|---|
+| split_bytes_read | Counter | Number of bytes read from bookkeeper. |
+| split_num_messages_deserialized | Counter | Number of messages deserialized. 
|
+| split_num_record_deserialized | Counter | Number of record deserialized. |
+| split_bytes_read_per_query | Summary | Total number of bytes read per query. 
|
+| split_entry_deserialize_time | Summary | Time spent derserializing entries. |
+| split_entry_deserialize_time_per_query | Summary | Time spent derserializing 
entries per query. |
+| split_entry_queue_dequeue_wait_time | Summary | Time spend waiting to get 
entry from entry queue because it is empty. |
+| split_entry_queue_dequeue_wait_time_per_query | Summary | Total time spend 
waiting to get entry from entry queue per query. |
+| split_message_queue_dequeue_wait_time_per_query | Summary | Time spent 
waiting to dequeue from message queue because its empty per query. |
+| split_message_queue_enqueue_wait_time | Summary | Time spent waiting for 
message queue enqueue because message queue is full. |
+| split_message_queue_enqueue_wait_time_per_query | Summary | Time spent 
waiting for message queue enqueue because message queue is full per query. |

Review comment:
       ```suggestion
   | split_message_queue_enqueue_wait_time_per_query | Summary | Time spent on 
waiting for message queue because the message queue is full per query. |
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to