merlimat commented on a change in pull request #310:
URL: https://github.com/apache/pulsar-client-go/pull/310#discussion_r451842150



##########
File path: perf/perf-producer.go
##########
@@ -62,6 +63,8 @@ func newProducerCommand() *cobra.Command {
                "Publish rate. Set to 0 to go unthrottled")
        flags.IntVarP(&produceArgs.BatchingTimeMillis, "batching-time", "b", 1,
                "Batching grouping time in millis")
+       flags.IntVarP(&produceArgs.BatchingMaxSize, "batching-max-size", "", 
128,
+               "Max size of a batch (in KB)")

Review comment:
       This are 2 different settings. One is the number of messages in 1 batch 
and the other is the max size of the batch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to