sijie commented on a change in pull request #7843:
URL: https://github.com/apache/pulsar/pull/7843#discussion_r478543501
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/functions/ProducerConfig.java
##########
@@ -36,4 +36,8 @@
private Integer maxPendingMessages;
private Integer maxPendingMessagesAcrossPartitions;
private Boolean useThreadLocalProducers;
+ private Boolean disableBatching;
+ private Integer batchingMaxPublishDelay;
Review comment:
```suggestion
private Integer batchingMaxPublishDelayMs;
```
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java
##########
@@ -110,6 +108,22 @@ protected PulsarSinkProcessorBase(Schema schema) {
if
(pulsarSinkConfig.getProducerSpec().getMaxPendingMessagesAcrossPartitions() !=
0) {
builder.maxPendingMessagesAcrossPartitions(pulsarSinkConfig.getProducerSpec().getMaxPendingMessagesAcrossPartitions());
}
+ if (!pulsarSinkConfig.getProducerSpec().getDisableBatching()) {
+ builder.enableBatching(true);
Review comment:
The batching is enabled by default in the builder. So I don't think this
change is able to disable batching.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
