aloyszhang commented on a change in pull request #7605:
URL: https://github.com/apache/pulsar/pull/7605#discussion_r499239138
##########
File path:
pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Lookup.java
##########
@@ -41,6 +42,14 @@
*/
CompletableFuture<String> lookupTopicAsync(String topic);
+ /**
+ * Lookup a partitioned topic.
+ *
+ * @param topic
+ * @return the broker URL that serves the topic
+ */
Review comment:
For the uniform of method name, we should add a `aync` method for
`lookupPartitionedTopic`.
But other method without `async` juset invoke the relative `async` method.
e.g.
`getBundleRange` just invoke `
getBundleRangeAsync(topic).get(this.readTimeoutMs, TimeUnit.MILLISECONDS)`
But, `lookupPartitionedTopic` internal invokes
`topics.getPartitionedTopicMetadataAsync(topic).get(this.readTimeoutMs,
TimeUnit.MILLISECONDS)` and
` lookupTopicAsync(partitionTopicName).get(readTimeoutMs,
TimeUnit.MILLISECONDS)`.
So it's hard to tell which is better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
