[GitHub] [pulsar] codelipenghui commented on a change in pull request #8612: [Transaction] Add the batch size in transaction ack command.

[GitBox]

codelipenghui commented on a change in pull request #8612:
URL: https://github.com/apache/pulsar/pull/8612#discussion_r526092501



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -391,7 +391,7 @@ public void readEntryFailed(ManagedLedgerException 
exception, Object ctx) {
                                                                     
List<MutablePair<PositionImpl, Long>> positions) {
         if (pendingAckHandle == null) {
             return FutureUtil.failedFuture(
-                    new TransactionConflictException("Broker does't support 
Transaction pending ack!"));
+                    new NotAllowedException("Broker does't support Transaction 
pending ack!"));

Review comment:
       ```suggestion
                       new NotAllowedException("The transaction is disabled"));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org