wuzhanpeng commented on a change in pull request #8946:
URL: https://github.com/apache/pulsar/pull/8946#discussion_r542085494
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -3300,6 +3305,13 @@ private void scheduleTimeoutTask() {
checkReadTimeout();
}), timeoutSec, timeoutSec, TimeUnit.SECONDS);
}
+
+ if (config.getMaximumRolloverTimeMs() > 0) {
Review comment:
I think it would be better to separate the timing task of checking that
current ledger is full from `scheduleTimeoutTask` and put it in the ledger
`initialize` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
