yufan022 commented on a change in pull request #8985:
URL: https://github.com/apache/pulsar/pull/8985#discussion_r546372775
##########
File path:
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/JCloudBlobStoreProvider.java
##########
@@ -162,6 +165,28 @@ public void buildCredentials(TieredStorageConfiguration
config) {
}
},
+
+ /**
+ * Aliyun OSS is compatible with the S3 API
+ * https://www.alibabacloud.com/help/doc-detail/64919.htm
+ */
+ ALIYUN_OSS("aliyun-oss", new AnonymousProviderMetadata(new
S3ApiMetadata(), "")) {
+ @Override
+ public void validate(TieredStorageConfiguration config) throws
IllegalArgumentException {
+ VALIDATION.validate(config);
+ }
+
+ @Override
+ public BlobStore getBlobStore(TieredStorageConfiguration config) {
+ return OSS_BLOB_STORE_BUILDER.getBlobStore(config);
Review comment:
if use `OSS_BLOB_STORE_BUILDER`,`OSS_VALIDATION` , it will only belongs
to Aliyun OSS.
But using `S3_API_BLOB_STORE_BUILDER`,`S3_API_VALIDATION` make it universal,
both make sense.
What's your suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
