aloyszhang commented on a change in pull request #9193:
URL: https://github.com/apache/pulsar/pull/9193#discussion_r556995964



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -812,7 +812,7 @@ protected boolean isNamespaceReplicated(NamespaceName 
namespaceName) {
         try {
             String topicPartitionPath = joinPath(MANAGED_LEDGER_PATH_ZNODE,
                     namespaceName.toString(), topicDomain.value());
-            List<String> topics = globalZk().getChildren(topicPartitionPath, 
false);
+            List<String> topics = localZk().getChildren(topicPartitionPath, 
false);

Review comment:
       Thanks for your suggestion @jiazhai @codelipenghui .
   I have test the `AdminApiTest2#testMaxTopicsPerNamespace` and found the 
globalZk and localZk return the same result , this is why the original test 
passed.
   I'll try to add two different zk for local and global respectively.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to