Jennifer88huang commented on a change in pull request #9215:
URL: https://github.com/apache/pulsar/pull/9215#discussion_r558093676
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java
##########
@@ -120,8 +120,7 @@ public CmdTopics(PulsarAdmin admin) {
jcommander.addCommand("set-retention", new SetRetention());
jcommander.addCommand("remove-retention", new RemoveRetention());
- jcommander.addCommand("enable-deduplication", new
EnableDeduplication());
- jcommander.addCommand("disable-deduplication", new
DisableDeduplication());
+ jcommander.addCommand("set-deduplication", new SetDeduplication());
jcommander.addCommand("get-deduplication-enabled", new
GetDeduplicationEnabled());
Review comment:
shall we use "get-deduplication-enabled" or "get-deduplication"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
