BewareMyPower commented on a change in pull request #9342:
URL: https://github.com/apache/pulsar/pull/9342#discussion_r566119409
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
##########
@@ -356,8 +356,6 @@ protected void validateTopicName(String property, String
namespace, String encod
topic, e);
throw new RestException(Status.PRECONDITION_FAILED, "Topic name is
not valid");
}
-
- this.topicName = TopicName.get(domain(), namespaceName, topic);
Review comment:
Yes, it's a repeated code (see line 353). I've modified this method
before, when I changed it back, I kept this line removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
