eolivelli commented on a change in pull request #9779: URL: https://github.com/apache/pulsar/pull/9779#discussion_r587200227
########## File path: site2/docs/reference-configuration.md ########## @@ -129,7 +129,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora |dbStorage_rocksDB_numLevels||-1| |dbStorage_rocksDB_numFilesInLevel0||4| |dbStorage_rocksDB_maxSizeInLevel1MB||256| - +bookieId | If you want to custom bookie ID or use a dynamic network address for the bookie, you can set this option. <br><br>Bookie advertises itself using `bookieId` rather than `BookieSocketAddress` (hostname:port or IP:port).<br><br> `bookieId` is a non empty string that can contain ASCII digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more information about `bookieId`, see [here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/| Review comment: probably it is better to move this line next to `useHostNameAsBookieID` Also probably it is worth telling that if you set a `bookieId` the `useHostNameAsBookieID` does not have effect ########## File path: site2/docs/reference-configuration.md ########## @@ -129,7 +129,7 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora |dbStorage_rocksDB_numLevels||-1| |dbStorage_rocksDB_numFilesInLevel0||4| |dbStorage_rocksDB_maxSizeInLevel1MB||256| - +bookieId | If you want to custom bookie ID or use a dynamic network address for the bookie, you can set this option. <br><br>Bookie advertises itself using `bookieId` rather than `BookieSocketAddress` (hostname:port or IP:port).<br><br> `bookieId` is a non empty string that can contain ASCII digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more information about `bookieId`, see [here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/| Review comment: Also I see that the default value that I see in the rendered table is '/', we should leave an empty string ########## File path: site2/docs/reference-configuration.md ########## @@ -657,6 +657,7 @@ The value of 0 disables message-byte dispatch-throttling.|0| |defaultRetentionSizeInMB| |0| |keepAliveIntervalSeconds| |30| haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false| +bookieId | If you want to custom bookie ID or use a dynamic network address for the bookie, you can set this option. <br><br>Bookie advertises itself using `bookieId` rather than `BookieSocketAddress` (hostname:port or IP:port).<br><br> `bookieId` is a non empty string that can contain ASCII digits and letters ([a-zA-Z9-0]), colons, dashes, and dots. <br><br>For more information about `bookieId`, see [here](http://bookkeeper.apache.org/bps/BP-41-bookieid/).|/| Review comment: same as above ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
