codelipenghui commented on a change in pull request #9903: URL: https://github.com/apache/pulsar/pull/9903#discussion_r593831359
########## File path: site2/docs/reference-configuration.md ########## @@ -340,26 +340,28 @@ subscriptionExpirationTimeMinutes | How long to delete inactive subscriptions fr |replicatedSubscriptionsSnapshotFrequencyMillis|The frequency of snapshots for replicated subscriptions tracking.|1000| |replicatedSubscriptionsSnapshotTimeoutSeconds|The timeout for building a consistent snapshot for tracking replicated subscriptions state.|30| |replicatedSubscriptionsSnapshotMaxCachedPerSubscription|The maximum number of snapshot to be cached per subscription.|10| -|maxMessagePublishBufferSizeInMB|The maximum memory size for broker handling messages sent from producers. If the processing message size exceeds this value, broker stops reading data from the connection. The processing messages means messages are sent to broker but broker have not sent response to the client. Usually the message are waiting to be written to bookies. It's shared across all the topics running in the same broker. The value `-1` disables the memory limitation. By default, it is 50% of direct memory.|N/A| +|maxMessagePublishBufferSizeInMB|The maximum memory size for a broker to handle messages that are sent by producers. If the processing message size exceeds this value, the broker stops reading data from the connection. The processing messages refer to the messages that are sent to the broker but the broker has not sent response to the client. Usually the messages are waiting to be written to bookies. It's shared across all the topics running in the same broker. The value `-1` disables the memory limitation. By default, it is 50% of direct memory.|N/A| |messagePublishBufferCheckIntervalInMillis|Interval between checks to see if message publish buffer size exceeds the maximum. Use `0` or negative number to disable the max publish buffer limiting.|100| |retentionCheckIntervalInSeconds|Check between intervals to see if consumed ledgers need to be trimmed. Use 0 or negative number to disable the check.|120| | maxMessageSize | Set the maximum size of a message. | 5242880 | | preciseTopicPublishRateLimiterEnable | Enable precise topic publish rate limiting. | false | | lazyCursorRecovery | Whether to recover cursors lazily when trying to recover a managed ledger backing a persistent topic. It can improve write availability of topics. The caveat is now when recovered ledger is ready to write we're not sure if all old consumers' last mark delete position(ack position) can be recovered or not. So user can make the trade off or have custom logic in application to checkpoint consumer state.| false | |haProxyProtocolEnabled | Enable or disable the [HAProxy](http://www.haproxy.org/) protocol. |false| | maxTopicsPerNamespace | The maximum number of persistent topics that can be created in the namespace. When the number of topics reaches this threshold, the broker rejects the request of creating a new topic, including the auto-created topics by the producer or consumer, until the number of connected consumers decreases. The default value 0 disables the check. | 0 | +|getSubscriptionTypesEnabled| Enable all subscription types, that is exclusive, shared, failover and key_shared, for a namespace or a topic. | true | +|setSubscriptionTypesEnabled| Enable one or more subscrption types for a namespace or a topic. Multiple subscription types are available, separated by `,`. You can set this parameter by `pulsar-admin namespaces set-subscription-types-enabled options` or `pulsar-admin topics set-subscription-types-enabled options` command. | null | Review comment: We don't have these 2 configurations in the broker.conf, the allowed config is `subscriptionTypesEnabled`. Here is the description in the broker.conf ``` # Enable subscription types (default is all type enabled) # SubscriptionTypes : Exclusive,Shared,Failover,Key_Shared # Example : Exclusive,Shared # Above example will disable Failover and Key_Shared subscription types subscriptionTypesEnabled=Exclusive,Shared,Failover,Key_Shared ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
