dlg99 commented on pull request #9927:
URL: https://github.com/apache/pulsar/pull/9927#issuecomment-800665584


   > I am not much convinced about the final packaging, because if you want to 
run an existing Kafka Sink you have to build this module and add that Sink as 
dependency (this is the same work we are doing with Debezium source?).
   
   Final packaging is tricky. 
   What I have is an option to get started quickly.
   I cannot include all possible kafka connect modules - most of the people 
will need only small subset of them (that's even if this won't create 
dependency conflicts), others will need some custom connector not available 
publicly.
   Passing a jar assumes the fat jar -> either shading (size of nar increases) 
or dependency conflicts.
   Merging two nars is an option 
https://jslabonte.wordpress.com/2012/02/01/how-to-merge-nar-files/ 
   Either way, another profile is not for production use (I can't imagine file 
sink being very useful) but to provide an example.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to