jerrypeng commented on pull request #9945: URL: https://github.com/apache/pulsar/pull/9945#issuecomment-802166287
@freeznet first of all thank you for looking into a solution for an existing issue. There definitely was a bug in the framework involving setting messaging properties. > like if a source connector is maintained by another orgs or devs, and it passes Record with properties that user doesn't need If the message properties not useful for users then why does the source set them. It seems like an issue with the source implementation. If there is a scenario in which setting message properties needs to be more configurable, then the source can support a configuration specific to the source and the end user can just use that knob. Also the name of the config is called `forwardSourceMessageProperty` which also makes little sense in the context of sources. It make sense in the context of the functions since functions do not necessarily control the the data it is reading but the source does. I would strongly suggest we revert this change and don't make this configurable at a framework level. The behavior for a source that sets properties is that they should automatically be applied to the underlying pulsar message. If there is custom behavior that needs happen in regards to message properties it should be a source specific configurations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
