[GitHub] [pulsar] gmethvin commented on a change in pull request #9440: [Issue 9438][pulsar-client] Fix inconsistent equals and hashCode for MessageIds

[GitBox]

gmethvin commented on a change in pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#discussion_r597305928



##########
File path: 
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java
##########
@@ -27,15 +27,22 @@
 import io.netty.util.concurrent.FastThreadLocal;
 
 import java.io.IOException;
+import java.util.Objects;
 
 import org.apache.pulsar.client.api.MessageId;
 import org.apache.pulsar.common.api.proto.MessageIdData;
 import org.apache.pulsar.common.naming.TopicName;
 
 public class MessageIdImpl implements MessageId {
+    protected static final int NO_BATCH = -1;
+
     protected final long ledgerId;
     protected final long entryId;
     protected final int partitionIndex;
+    protected final int batchIndex;
+    protected final int batchSize;
+
+    protected final transient BatchMessageAcker acker;

Review comment:
       If we can remove the `BatchMessageIdImpl` type completely that'd be 
great. It just seemed like it wouldn't be possible due to backwards 
compatibility concerns. I'm not sure I understand the benefit of having 
multiple types.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org