lhotari commented on pull request #9963:
URL: https://github.com/apache/pulsar/pull/9963#issuecomment-802662390


   Some notes about paths-filters usage for future reference:
   
   - for testing paths-filter filter syntax, these commands can be used:
   ```
     npm install picomatch
     node -e "console.log(require('picomatch')('**/*.md', {'dot': 
true})('some/path/README.md'));"
   ```
   - it's not recommended to use complex patterns with picomatch since the
     results might be surprising.
   
   - Inversions in picomatch don't work as expected, that might be due to
     the ["dot file" handling in 
picomatch](https://github.com/dorny/paths-filter#notes).
     - this is the reason to use the `steps.changes.outputs.all_count > 
steps.changes.outputs.docs_count` comparison to check if there are other than 
documentation changes. An inversion based approach didn't produce correct 
results.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to