eolivelli commented on a change in pull request #9802:
URL: https://github.com/apache/pulsar/pull/9802#discussion_r601631188
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
##########
@@ -71,6 +73,7 @@
public class ProxyService implements Closeable {
private final ProxyConfiguration proxyConfig;
+ private Timer shareTimer;
Review comment:
nit: make it `final` and name it "sharedTimer" or simply "timer"
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
##########
@@ -131,6 +134,7 @@ public ProxyService(ProxyConfiguration proxyConfig,
AuthenticationService authenticationService) throws
IOException {
checkNotNull(proxyConfig);
this.proxyConfig = proxyConfig;
+ this.shareTimer = new HashedWheelTimer(new
DefaultThreadFactory("pulsar-share-timer", Thread.currentThread().isDaemon()),
1, TimeUnit.MILLISECONDS);
Review comment:
"pulsar-share-timer" -> "pulsar-timer" ?
##########
File path:
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
##########
@@ -287,6 +294,10 @@ public ProxyConfiguration getConfiguration() {
return proxyConfig;
}
+ public Timer getShareTimer() {
Review comment:
getTimer() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
