[GitHub] [pulsar] lhotari commented on a change in pull request #9308: Wait for the async broker port listener close operations to complete at shutdown

[GitBox]

lhotari commented on a change in pull request #9308:
URL: https://github.com/apache/pulsar/pull/9308#discussion_r602249951



##########
File path: 
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -120,13 +120,18 @@
         category = CATEGORY_SERVER,
         doc = "The port for serving binary protobuf requests"
     )
-
     private Optional<Integer> brokerServicePort = Optional.of(6650);
     @FieldContext(
         category = CATEGORY_SERVER,
         doc = "The port for serving tls secured binary protobuf requests"
     )
     private Optional<Integer> brokerServicePortTls = Optional.empty();
+    @FieldContext(
+            category = CATEGORY_SERVER,
+            doc = "The maximum duration (in seconds) to wait for each broker 
service network port to close "
+                    + "at broker service shutdown. No waiting will take place 
when the value is set to <= 0."
+    )
+    private int brokerServicePortCloseTimeoutInSeconds = 2;

Review comment:
       The final changes in this PR are addressing Matteo's proposal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org