lhotari commented on pull request #10148:
URL: https://github.com/apache/pulsar/pull/10148#issuecomment-815221488


   > It will create confusion, user context in java is at a class level, this 
is enforced at file per class convention. Saying there are two executions of 
test one under a standard context one under a quarantine context will only 
confuse individuals.
   > 
   
   Things seem to work fine with the changes in this PR. Can you provide an 
example of a possible confusion? 
   
   > To run them you will need to create boolean set evaluation rules to 
isolate methods, testng does not have a clean abstraction to do so.
   
   The only requirement I found was to use `alwaysRun = true` for `@Before*` 
methods instead of listing groups. Besides that, the solution passes  
`quarantine` in `excludedGroups` by default and when running quarantine tests, 
it passes `quarantine` in `groups` and an empty string to `excludedGroups`. 
Isn't this fine?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to