lhotari commented on a change in pull request #10180: URL: https://github.com/apache/pulsar/pull/10180#discussion_r610756824
########## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java ########## @@ -175,7 +175,7 @@ public synchronized void removeConsumer(Consumer consumer) throws BrokerServiceE log.info("[{}] All consumers removed. Subscription is disconnected", name); closeFuture.complete(null); } - totalAvailablePermits = 0; + TOTAL_AVAILABLE_PERMITS_UPDATER.set(this, 0); Review comment: true. I tried to make it consistent with the style used in NonPersistentDispatcherMultipleConsumers: https://github.com/apache/pulsar/blob/31f831574c3a65bae0e76801facaf2deb0b17fbb/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentDispatcherMultipleConsumers.java#L104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org