lhotari commented on a change in pull request #10199:
URL: https://github.com/apache/pulsar/pull/10199#discussion_r614694023
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -480,6 +487,20 @@ public void close() throws PulsarServerException {
}
}
+ private CompletableFuture<Void> addTimeoutHandling(CompletableFuture<Void>
future) {
+ ScheduledExecutorService shutdownExecutor =
Executors.newSingleThreadScheduledExecutor(
+ new DefaultThreadFactory(getClass().getSimpleName() +
"-shutdown"));
+ FutureUtil.addTimeoutHandling(future,
+ Duration.ofMillis(Math.max(1L,
getConfiguration().getBrokerShutdownTimeoutMs())),
+ shutdownExecutor, () ->
FutureUtil.createTimeoutException("Timeout in close", getClass(), "close"));
+ future.handle((v, t) -> {
+ // shutdown the shutdown executor
+ shutdownExecutor.shutdown();
Review comment:
oh sorry, I didn't look at the full context of the code where this was.
In this case, I'll simply use `shutdownNow` to terminate the scheduler used to
schedule the timeout handling for the CompletableFuture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
