[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #10254: [Broker] Remove possible error case for system topic name checking

[GitBox]

michaeljmarshall commented on a change in pull request #10254:
URL: https://github.com/apache/pulsar/pull/10254#discussion_r615315074



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -643,7 +643,8 @@ protected void handleProducerRemoved(Producer producer) {
         }
 
         try {
-            if (!topic.endsWith(EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME)
+            // TODO can all system topics have any type of subscription?
+            if 
(!TopicName.get(topic).getLocalName().equals(EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME)

Review comment:
       `TRANSACTION_BUFFER_SNAPSHOT` was not included in this check. Should it 
be?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org