david-streamlio opened a new pull request #10270:
URL: https://github.com/apache/pulsar/pull/10270
Fixes #10269
### Motivation
When an Error or Exception occurs in write() method of the sink, the error
is logged but no actions are performed. We need the exception to be re-thrown
so that the user/framework can be made aware of the underlying issue rather
than having the Sink continuously failing silently, e.g. zombie sink instances
that are running but not making any progress.
### Modifications
Added logic to re-throw an exception if one is encountered inside the
processResult() method of the JavaInstanceRunnable class
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
- If a feature is not applicable for documentation, explain why? This is a
bug fix to correct the behavior of a Sink when an exception is thrown
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
