lhotari commented on pull request #10276: URL: https://github.com/apache/pulsar/pull/10276#issuecomment-823006051
> I added comments to this staging PR [michaeljmarshall#2](https://github.com/michaeljmarshall/pulsar/pull/2) to show where and how I tested the changes. Yes, really good. I checked that while reviewing. > I haven't been able to find explicit documentation on this specific case of interpolation yet. However, it does seem that this change produces the expected outcome for the affected tests. The documentation is here: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#about-contexts-and-expressions . However there isn't a clear answer. What seems to happen is that when using this syntax: ``` if: ${{ steps.changes.outputs.all_count > steps.changes.outputs.docs_count }} ``` the values are compared as string values and not numeric values. In the example case, `"40" > "7"` is false. When using the other syntax, the explicit expressions `${{ .... }}` will trigger the autodetection of the value. This converts them into numbers ``` if: ${{ steps.changes.outputs.all_count }} > ${{ steps.changes.outputs.docs_count }} ``` Now `40 > 7` is true. There is no documentation about how to explicitly convert value to a number. I believe that your fix is the correct way to do it. Thanks for saving my day @michaeljmarshall ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
