david-streamlio commented on a change in pull request #10270:
URL: https://github.com/apache/pulsar/pull/10270#discussion_r616998062
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -269,9 +270,11 @@ public void run() {
try {
processResult(currentRecord, result);
- } catch (Exception e) {
+ result.join();
Review comment:
@jerrypeng Agreed on both points. However, we still need to address the
async use case scenario. I am thinking that a shared data struct can be used by
the Futures to communicate exceptions, and the main thread can check the data
struct for the presence of any errors and if one is found raise the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
