[GitHub] [pulsar] RobertIndie commented on pull request #10420: [Kinesis]Fix kinesis sink can not retry to send messages

[GitBox]

RobertIndie commented on pull request #10420:
URL: https://github.com/apache/pulsar/pull/10420#issuecomment-829228354


   Here I did some stress tests:
   * Start the sink connector with `retainOrdering` enabled.
   
![image](https://user-images.githubusercontent.com/16974619/116555693-40c2d700-a92f-11eb-9c35-97213f4cddde.png)
   * Disconnect the network to let the kinesis producer fails to send messages.
   * Produce 1 million messages with rate 100000/s.
   
![image](https://user-images.githubusercontent.com/16974619/116555868-6fd94880-a92f-11eb-8252-b70c9a31e2c0.png)
   * The sink connector will skip all the subsequent messages to retain 
ordering.
   
![image](https://user-images.githubusercontent.com/16974619/116555963-87183600-a92f-11eb-8fd0-ff24f8e28033.png)
   * The memory of sink connector has not grown significantly.
   
   When `retainOrdering` is disabled, there will be no retry. The changes made 
by this PR will not affect this case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org