atezs82 commented on pull request #10574:
URL: https://github.com/apache/pulsar/pull/10574#issuecomment-844071384


   @merlimat Please excuse my limited knowledge on the `pulsar-client`. On the 
other hand, it seems that you have handled this Findbugs issue in the 
`AuthenticationTls` class as well (line 49):
   ```java
   @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "Using custom 
serializer which Findbugs can't detect")
   private Supplier<ByteArrayInputStream> certStreamProvider, 
keyStreamProvider, trustStoreStreamProvider;
   ``` 
   Based on this, I also added a similar suppress annotation to 
`AuthenticationDataTls` (I am not exactly sure why this was missing from there 
though).
   
   Let me know if this approach shall be OK or shall I modify the custom 
deserializer logic instead. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to