wuzhanpeng commented on pull request #10707:
URL: https://github.com/apache/pulsar/pull/10707#issuecomment-848431085


   @codelipenghui @zhaijack @sijie @hangc0276 @eolivelli @merlimat 
   
   The above PR modification only affects the result of fetching partition 
metadata, and has no effect on other existing operations. But I'm thinking that 
modifying `MetadataCacheImpl#delete` may be a more thorough plan. 
   
   ```java
   @Override
   public CompletableFuture<Void> delete(String path) {
       return store.delete(path, Optional.empty())
               .thenAccept(v -> {
                   // Mark in the cache that the object was removed
                   objCache.put(path, FutureUtils.value(Optional.empty()));
               });
   }
   ```
   What makes me wonder is why this place did not directly invalidate the path, 
but made into an assignment operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to